aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorgingerBill <gingerBill@users.noreply.github.com>2025-09-28 23:53:07 +0100
committergingerBill <gingerBill@users.noreply.github.com>2025-09-28 23:53:07 +0100
commit4877214f34abbccb8d7b11d773371fa935fe73d3 (patch)
treeeeb46441263d048145da28b9b7aabeafc89e229d
parentdd15a5bc8e546177f5a7ac89df464c3ed1e9c305 (diff)
Add more `check_is_operand_compound_lit_constant` uses
-rw-r--r--src/check_expr.cpp20
-rw-r--r--src/llvm_backend.cpp10
-rw-r--r--src/types.cpp5
3 files changed, 28 insertions, 7 deletions
diff --git a/src/check_expr.cpp b/src/check_expr.cpp
index a59dbdc42..10fec1890 100644
--- a/src/check_expr.cpp
+++ b/src/check_expr.cpp
@@ -8686,8 +8686,12 @@ gb_internal bool check_is_operand_compound_lit_constant(CheckerContext *c, Opera
}
}
if (field_type != nullptr && is_type_typeid(field_type) && o->mode == Addressing_Type) {
+ add_type_info_type(c, o->type);
return true;
}
+ if (is_type_any(field_type)) {
+ return false;
+ }
return o->mode == Addressing_Constant;
}
@@ -10052,7 +10056,9 @@ gb_internal ExprKind check_compound_literal(CheckerContext *c, Operand *o, Ast *
check_expr_with_type_hint(c, &operand, fv->value, elem_type);
check_assignment(c, &operand, elem_type, context_name);
- is_constant = is_constant && operand.mode == Addressing_Constant;
+ if (is_constant) {
+ is_constant = check_is_operand_compound_lit_constant(c, &operand, elem_type);
+ }
} else {
Operand op_index = {};
check_expr(c, &op_index, fv->field);
@@ -10289,7 +10295,9 @@ gb_internal ExprKind check_compound_literal(CheckerContext *c, Operand *o, Ast *
check_expr_with_type_hint(c, &operand, fv->value, elem_type);
check_assignment(c, &operand, elem_type, context_name);
- is_constant = is_constant && operand.mode == Addressing_Constant;
+ if (is_constant) {
+ is_constant = check_is_operand_compound_lit_constant(c, &operand, elem_type);
+ }
TokenKind upper_op = Token_LtEq;
if (op.kind == Token_RangeHalf) {
@@ -10330,7 +10338,9 @@ gb_internal ExprKind check_compound_literal(CheckerContext *c, Operand *o, Ast *
check_expr_with_type_hint(c, &operand, fv->value, elem_type);
check_assignment(c, &operand, elem_type, context_name);
- is_constant = is_constant && operand.mode == Addressing_Constant;
+ if (is_constant) {
+ is_constant = check_is_operand_compound_lit_constant(c, &operand, elem_type);
+ }
add_to_seen_map(c, &seen, op_index);
}
@@ -10360,7 +10370,9 @@ gb_internal ExprKind check_compound_literal(CheckerContext *c, Operand *o, Ast *
check_expr_with_type_hint(c, &operand, e, elem_type);
check_assignment(c, &operand, elem_type, context_name);
- is_constant = is_constant && operand.mode == Addressing_Constant;
+ if (is_constant) {
+ is_constant = check_is_operand_compound_lit_constant(c, &operand, elem_type);
+ }
}
if (max < index) {
diff --git a/src/llvm_backend.cpp b/src/llvm_backend.cpp
index 873f67cde..6a15e11a6 100644
--- a/src/llvm_backend.cpp
+++ b/src/llvm_backend.cpp
@@ -1947,7 +1947,7 @@ gb_internal bool lb_init_global_var(lbModule *m, lbProcedure *p, Entity *e, Ast
GB_PANIC("Invalid init value, got %s", expr_to_string(init_expr));
}
- if (is_type_any(e->type) || is_type_union(e->type)) {
+ if (is_type_any(e->type)) {
var.init = init;
} else if (lb_is_const_or_global(init)) {
if (!var.is_initialized) {
@@ -3272,7 +3272,7 @@ gb_internal bool lb_generate_code(lbGenerator *gen) {
if (decl->init_expr != nullptr) {
TypeAndValue tav = type_and_value_of_expr(decl->init_expr);
- if (!is_type_any(e->type) && !is_type_union(e->type)) {
+ if (!is_type_any(e->type)) {
if (tav.mode != Addressing_Invalid) {
if (tav.value.kind != ExactValue_Invalid) {
auto cc = LB_CONST_CONTEXT_DEFAULT;
@@ -3287,6 +3287,12 @@ gb_internal bool lb_generate_code(lbGenerator *gen) {
g.value = nullptr;
g.value = LLVMAddGlobal(m->mod, LLVMTypeOf(init.value), alloc_cstring(permanent_allocator(), name));
+ if (e->token.string == "node_camera_info") {
+ gb_printf_err("HERE!\n");
+ gb_printf_err("%s\n", LLVMPrintValueToString(init.value));
+ }
+
+
LLVMSetInitializer(g.value, init.value);
var.is_initialized = true;
if (cc.is_rodata) {
diff --git a/src/types.cpp b/src/types.cpp
index 814f99eff..62e47259d 100644
--- a/src/types.cpp
+++ b/src/types.cpp
@@ -2536,7 +2536,10 @@ gb_internal bool elem_type_can_be_constant(Type *t) {
if (t == t_invalid) {
return false;
}
- if (is_type_any(t) || is_type_raw_union(t)) {
+ if (is_type_any(t)) {
+ return false;
+ }
+ if (is_type_raw_union(t)) {
return false;
}
if (is_type_union(t)) {