diff options
| author | Laytan <laytanlaats@hotmail.com> | 2025-12-20 21:18:44 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-20 21:18:44 +0100 |
| commit | 00ede472e3adacafa9eaa3a64db5104169c9a0cd (patch) | |
| tree | be8112ff9623f6f452a7cf47bd78e02b12b2f3fa | |
| parent | 40267e3a7a66766b0562853f3ad219e08cb2fc20 (diff) | |
| parent | 67177db0a8e20e262c05e138ea10b7162da1a30f (diff) | |
Merge pull request #6046 from laytan/use-readfile-for-console-too
os/os2: use ReadFile for Console reads too, at least for now
| -rw-r--r-- | core/os/os2/file_windows.odin | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/core/os/os2/file_windows.odin b/core/os/os2/file_windows.odin index 7c075b7b1..9a969f07e 100644 --- a/core/os/os2/file_windows.odin +++ b/core/os/os2/file_windows.odin @@ -372,7 +372,10 @@ _read_internal :: proc(f: ^File_Impl, p: []byte) -> (n: i64, err: Error) { to_read := min(win32.DWORD(length), MAX_RW) switch f.kind { case .Console: - total_read, err = read_console(handle, p[total_read:][:to_read]) + // NOTE(laytan): at least for now, just use ReadFile, it seems to work fine, + // but, there may be issues with certain situations that we need to get reproductions for. + // total_read, err = read_console(handle, p[total_read:][:to_read]) + fallthrough case .Pipe, .File: single_read_length: win32.DWORD ok := win32.ReadFile(handle, &p[total_read], to_read, &single_read_length, nil) |