aboutsummaryrefslogtreecommitdiff
path: root/src/entity.cpp
diff options
context:
space:
mode:
authorgingerBill <bill@gingerbill.org>2023-08-01 11:39:04 +0100
committergingerBill <bill@gingerbill.org>2023-08-01 11:39:04 +0100
commit65206fe33e52a707134c919c01a0f8ae2d19c2d8 (patch)
tree2280e4e6c075e59eef0d86a269209641feeb843c /src/entity.cpp
parent2f094134a3e54cb6b99daf09b6a257b36f182b6e (diff)
Go through loads of `TODO`s
Diffstat (limited to 'src/entity.cpp')
-rw-r--r--src/entity.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/entity.cpp b/src/entity.cpp
index 649dd900d..291ae8c83 100644
--- a/src/entity.cpp
+++ b/src/entity.cpp
@@ -287,7 +287,6 @@ gb_internal bool is_entity_kind_exported(EntityKind kind, bool allow_builtin = f
}
gb_internal bool is_entity_exported(Entity *e, bool allow_builtin = false) {
- // TODO(bill): Determine the actual exportation rules for imports of entities
GB_ASSERT(e != nullptr);
if (!is_entity_kind_exported(e->kind, allow_builtin)) {
return false;
@@ -401,7 +400,7 @@ gb_internal Entity *alloc_entity_array_elem(Scope *scope, Token token, Type *typ
return entity;
}
-gb_internal Entity *alloc_entity_procedure(Scope *scope, Token token, Type *signature_type, u64 tags) {
+gb_internal Entity *alloc_entity_procedure(Scope *scope, Token token, Type *signature_type, u64 tags=0) {
Entity *entity = alloc_entity(Entity_Procedure, scope, token, signature_type);
entity->Procedure.tags = tags;
return entity;
@@ -418,7 +417,7 @@ gb_internal Entity *alloc_entity_import_name(Scope *scope, Token token, Type *ty
entity->ImportName.path = path;
entity->ImportName.name = name;
entity->ImportName.scope = import_scope;
- entity->state = EntityState_Resolved; // TODO(bill): Is this correct?
+ entity->state = EntityState_Resolved;
return entity;
}
@@ -427,7 +426,7 @@ gb_internal Entity *alloc_entity_library_name(Scope *scope, Token token, Type *t
Entity *entity = alloc_entity(Entity_LibraryName, scope, token, type);
entity->LibraryName.paths = paths;
entity->LibraryName.name = name;
- entity->state = EntityState_Resolved; // TODO(bill): Is this correct?
+ entity->state = EntityState_Resolved;
return entity;
}