aboutsummaryrefslogtreecommitdiff
path: root/src/exact_value.cpp
diff options
context:
space:
mode:
authorgingerBill <bill@gingerbill.org>2023-08-01 11:39:04 +0100
committergingerBill <bill@gingerbill.org>2023-08-01 11:39:04 +0100
commit65206fe33e52a707134c919c01a0f8ae2d19c2d8 (patch)
tree2280e4e6c075e59eef0d86a269209641feeb843c /src/exact_value.cpp
parent2f094134a3e54cb6b99daf09b6a257b36f182b6e (diff)
Go through loads of `TODO`s
Diffstat (limited to 'src/exact_value.cpp')
-rw-r--r--src/exact_value.cpp7
1 files changed, 2 insertions, 5 deletions
diff --git a/src/exact_value.cpp b/src/exact_value.cpp
index ff940aabb..cd499272f 100644
--- a/src/exact_value.cpp
+++ b/src/exact_value.cpp
@@ -26,8 +26,8 @@ enum ExactValueKind {
ExactValue_Complex = 5,
ExactValue_Quaternion = 6,
ExactValue_Pointer = 7,
- ExactValue_Compound = 8, // TODO(bill): Is this good enough?
- ExactValue_Procedure = 9, // TODO(bill): Is this good enough?
+ ExactValue_Compound = 8,
+ ExactValue_Procedure = 9,
ExactValue_Typeid = 10,
ExactValue_Count,
@@ -101,7 +101,6 @@ gb_internal ExactValue exact_value_bool(bool b) {
}
gb_internal ExactValue exact_value_string(String string) {
- // TODO(bill): Allow for numbers with underscores in them
ExactValue result = {ExactValue_String};
result.value_string = string;
return result;
@@ -702,7 +701,6 @@ gb_internal void match_exact_values(ExactValue *x, ExactValue *y) {
compiler_error("match_exact_values: How'd you get here? Invalid ExactValueKind %d", x->kind);
}
-// TODO(bill): Allow for pointer arithmetic? Or are pointer slices good enough?
gb_internal ExactValue exact_binary_operator_value(TokenKind op, ExactValue x, ExactValue y) {
match_exact_values(&x, &y);
@@ -943,7 +941,6 @@ gb_internal bool compare_exact_values(TokenKind op, ExactValue x, ExactValue y)
case ExactValue_String: {
String a = x.value_string;
String b = y.value_string;
- // TODO(bill): gb_memcompare is used because the strings are UTF-8
switch (op) {
case Token_CmpEq: return a == b;
case Token_NotEq: return a != b;