aboutsummaryrefslogtreecommitdiff
path: root/src/llvm_backend_expr.cpp
diff options
context:
space:
mode:
authorgingerBill <bill@gingerbill.org>2022-11-01 13:14:20 +0000
committergingerBill <bill@gingerbill.org>2022-11-01 13:14:20 +0000
commit2b7ca2bdd6be41abeb8ab5c5fa91f24657996e88 (patch)
treecdba200a615349a1c33b68a4becf4ebda3da35ef /src/llvm_backend_expr.cpp
parent411c0add3b2394a222ff341d88aef512c554c050 (diff)
Fix #2160 (deep subtyping through `using` of `_`)
Diffstat (limited to 'src/llvm_backend_expr.cpp')
-rw-r--r--src/llvm_backend_expr.cpp47
1 files changed, 23 insertions, 24 deletions
diff --git a/src/llvm_backend_expr.cpp b/src/llvm_backend_expr.cpp
index f26b990ff..05a9fdfbf 100644
--- a/src/llvm_backend_expr.cpp
+++ b/src/llvm_backend_expr.cpp
@@ -1952,34 +1952,33 @@ lbValue lb_emit_conv(lbProcedure *p, lbValue value, Type *t) {
Type *dt = t;
GB_ASSERT(is_type_struct(st) || is_type_raw_union(st));
- String field_name = lookup_subtype_polymorphic_field(t, src_type);
- if (field_name.len > 0) {
- // NOTE(bill): It can be casted
- Selection sel = lookup_field(st, field_name, false, true);
- if (sel.entity != nullptr) {
- if (st_is_ptr) {
- lbValue res = lb_emit_deep_field_gep(p, value, sel);
- Type *rt = res.type;
+ Selection sel = {};
+ sel.index.allocator = heap_allocator();
+ defer (array_free(&sel.index));
+ if (lookup_subtype_polymorphic_selection(t, src_type, &sel)) {
+ if (sel.entity == nullptr) {
+ GB_PANIC("invalid subtype cast %s -> ", type_to_string(src_type), type_to_string(t));
+ }
+ if (st_is_ptr) {
+ lbValue res = lb_emit_deep_field_gep(p, value, sel);
+ Type *rt = res.type;
+ if (!are_types_identical(rt, dt) && are_types_identical(type_deref(rt), dt)) {
+ res = lb_emit_load(p, res);
+ }
+ return res;
+ } else {
+ if (is_type_pointer(value.type)) {
+ Type *rt = value.type;
if (!are_types_identical(rt, dt) && are_types_identical(type_deref(rt), dt)) {
- res = lb_emit_load(p, res);
- }
- return res;
- } else {
- if (is_type_pointer(value.type)) {
- Type *rt = value.type;
- if (!are_types_identical(rt, dt) && are_types_identical(type_deref(rt), dt)) {
- value = lb_emit_load(p, value);
- } else {
- value = lb_emit_deep_field_gep(p, value, sel);
- return lb_emit_load(p, value);
- }
+ value = lb_emit_load(p, value);
+ } else {
+ value = lb_emit_deep_field_gep(p, value, sel);
+ return lb_emit_load(p, value);
}
+ }
- return lb_emit_deep_field_ev(p, value, sel);
+ return lb_emit_deep_field_ev(p, value, sel);
- }
- } else {
- GB_PANIC("invalid subtype cast %s.%.*s", type_to_string(src_type), LIT(field_name));
}
}
}