From 3ff887c6b6b838e9d4932b78ef1ac9319f522d8f Mon Sep 17 00:00:00 2001 From: Laytan Laats Date: Wed, 2 Oct 2024 15:55:46 +0200 Subject: fix not erroring on invalid ternary For example: `a: f32 = true ? 1 : len` would get to the back-end without errors. Fixes #1690 --- src/check_expr.cpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/check_expr.cpp') diff --git a/src/check_expr.cpp b/src/check_expr.cpp index fc1aa62e6..3b61e049c 100644 --- a/src/check_expr.cpp +++ b/src/check_expr.cpp @@ -8795,11 +8795,6 @@ gb_internal ExprKind check_ternary_if_expr(CheckerContext *c, Operand *o, Ast *n return kind; } - if (x.type == nullptr || x.type == t_invalid || - y.type == nullptr || y.type == t_invalid) { - return kind; - } - bool use_type_hint = type_hint != nullptr && (is_operand_nil(x) || is_operand_nil(y)); convert_to_typed(c, &x, use_type_hint ? type_hint : y.type); -- cgit v1.2.3