From 94d298755a6036c3dbbf95aed3299e021c3fb9c8 Mon Sep 17 00:00:00 2001 From: gingerBill Date: Mon, 16 Aug 2021 15:33:26 +0100 Subject: Fix race condition when adding a dependency --- src/check_expr.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/check_expr.cpp') diff --git a/src/check_expr.cpp b/src/check_expr.cpp index 30f44a59f..e0eb5a954 100644 --- a/src/check_expr.cpp +++ b/src/check_expr.cpp @@ -4117,20 +4117,23 @@ bool check_identifier_exists(Scope *s, Ast *node, bool nested = false, Scope **o } isize add_dependencies_from_unpacking(CheckerContext *c, Entity **lhs, isize lhs_count, isize tuple_index, isize tuple_count) { - if (lhs != nullptr) { + if (lhs != nullptr && c->decl != nullptr) { + mutex_lock(&c->info->deps_mutex); + for (isize j = 0; (tuple_index + j) < lhs_count && j < tuple_count; j++) { Entity *e = lhs[tuple_index + j]; if (e != nullptr) { DeclInfo *decl = decl_info_of_entity(e); if (decl != nullptr) { - c->decl = decl; // will be reset by the 'defer' any way for_array(k, decl->deps.entries) { Entity *dep = decl->deps.entries[k].ptr; - add_declaration_dependency(c, dep); // TODO(bill): Should this be here? + ptr_set_add(&c->decl->deps, dep); } } } } + + mutex_unlock(&c->info->deps_mutex); } return tuple_count; } -- cgit v1.2.3