From da283d5a7fb531427e74cb6003f451cb9b15f0ca Mon Sep 17 00:00:00 2001 From: gingerBill Date: Thu, 12 Mar 2020 22:33:49 +0000 Subject: Add `byval` --- src/ir_print.cpp | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) (limited to 'src/ir_print.cpp') diff --git a/src/ir_print.cpp b/src/ir_print.cpp index bcbdca615..d5271444d 100644 --- a/src/ir_print.cpp +++ b/src/ir_print.cpp @@ -363,6 +363,9 @@ void ir_print_proc_type_without_pointer(irFileBuffer *f, irModule *m, Type *t) { if (e->flags&EntityFlag_NoAlias) { ir_write_str_lit(f, " noalias"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } ir_write_byte(f, ' '); param_index++; } @@ -2184,6 +2187,9 @@ void ir_print_instr(irFileBuffer *f, irModule *m, irValue *value) { if (e->flags&EntityFlag_NoAlias) { ir_write_str_lit(f, " noalias"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } ir_write_byte(f, ' '); ir_print_value(f, m, arg, t); param_index++; @@ -2196,6 +2202,9 @@ void ir_print_instr(irFileBuffer *f, irModule *m, irValue *value) { if (e->flags&EntityFlag_ImplicitReference) { ir_write_str_lit(f, " nonnull dereferenceable"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } ir_write_byte(f, ' '); irValue *arg = call->args[arg_index++]; ir_print_value(f, m, arg, t); @@ -2236,6 +2245,9 @@ void ir_print_instr(irFileBuffer *f, irModule *m, irValue *value) { if (e->flags&EntityFlag_NoAlias) { ir_write_str_lit(f, " noalias"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } ir_write_byte(f, ' '); ir_print_value(f, m, arg, t); param_index++; @@ -2246,6 +2258,9 @@ void ir_print_instr(irFileBuffer *f, irModule *m, irValue *value) { if (e->flags&EntityFlag_NoAlias) { ir_write_str_lit(f, " noalias"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } ir_write_byte(f, ' '); ir_print_value(f, m, arg, t); param_index++; @@ -2390,6 +2405,10 @@ void ir_print_proc(irFileBuffer *f, irModule *m, irProcedure *proc) { if (e->flags&EntityFlag_NoAlias) { ir_write_str_lit(f, " noalias"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } + if (proc->body != nullptr) { ir_fprintf(f, " %%_.%td", parameter_index+j); @@ -2402,6 +2421,9 @@ void ir_print_proc(irFileBuffer *f, irModule *m, irProcedure *proc) { if (e->flags&EntityFlag_NoAlias) { ir_write_str_lit(f, " noalias"); } + if (e->flags&EntityFlag_ByVal) { + ir_write_str_lit(f, " byval"); + } if (proc->body != nullptr) { ir_fprintf(f, " %%_.%td", parameter_index); } -- cgit v1.2.3 From 06e364b9bd0761aa6445d8c630ee283694925b05 Mon Sep 17 00:00:00 2001 From: gingerBill Date: Fri, 13 Mar 2020 08:52:23 +0000 Subject: Apply byval to sret for System V ABI --- src/ir_print.cpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'src/ir_print.cpp') diff --git a/src/ir_print.cpp b/src/ir_print.cpp index d5271444d..fb224648d 100644 --- a/src/ir_print.cpp +++ b/src/ir_print.cpp @@ -338,9 +338,13 @@ void ir_print_proc_type_without_pointer(irFileBuffer *f, irModule *m, Type *t) { ir_write_string(f, str_lit(" (")); if (t->Proc.return_by_pointer) { ir_print_type(f, m, reduce_tuple_to_single_type(t->Proc.results)); - // ir_fprintf(f, "* sret noalias "); + ir_fprintf(f, "* sret noalias "); + if (build_context.ODIN_OS == "darwin" || + build_context.ODIN_OS == "linux") { + ir_fprintf(f, "byval "); + } // ir_write_string(f, str_lit("* noalias ")); - ir_write_string(f, str_lit("*")); + // ir_write_string(f, str_lit("*")); if (param_count > 0 || t->Proc.calling_convention == ProcCC_Odin) { ir_write_string(f, str_lit(", ")); } @@ -2379,6 +2383,10 @@ void ir_print_proc(irFileBuffer *f, irModule *m, irProcedure *proc) { if (proc_type->return_by_pointer) { ir_print_type(f, m, reduce_tuple_to_single_type(proc_type->results)); ir_write_str_lit(f, "* sret noalias "); + if (build_context.ODIN_OS == "darwin" || + build_context.ODIN_OS == "linux") { + ir_fprintf(f, "byval "); + } ir_write_str_lit(f, "%agg.result"); param_index += 1; } -- cgit v1.2.3 From 10bac2445bb4e0e2b8e3b229f79a4bae9dedfdf7 Mon Sep 17 00:00:00 2001 From: gingerBill Date: Fri, 13 Mar 2020 16:48:10 +0000 Subject: Fix ir_print for byval types --- src/ir_print.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/ir_print.cpp') diff --git a/src/ir_print.cpp b/src/ir_print.cpp index fb224648d..6c1b5a792 100644 --- a/src/ir_print.cpp +++ b/src/ir_print.cpp @@ -338,13 +338,13 @@ void ir_print_proc_type_without_pointer(irFileBuffer *f, irModule *m, Type *t) { ir_write_string(f, str_lit(" (")); if (t->Proc.return_by_pointer) { ir_print_type(f, m, reduce_tuple_to_single_type(t->Proc.results)); - ir_fprintf(f, "* sret noalias "); + // ir_fprintf(f, "* sret noalias "); + // ir_write_string(f, str_lit("* noalias ")); + ir_write_string(f, str_lit("*")); if (build_context.ODIN_OS == "darwin" || build_context.ODIN_OS == "linux") { - ir_fprintf(f, "byval "); + ir_fprintf(f, " byval"); } - // ir_write_string(f, str_lit("* noalias ")); - // ir_write_string(f, str_lit("*")); if (param_count > 0 || t->Proc.calling_convention == ProcCC_Odin) { ir_write_string(f, str_lit(", ")); } -- cgit v1.2.3