From a631a5d232927c658968c3d6040c46b11f2d412b Mon Sep 17 00:00:00 2001
From: Brad Lewis <22850972+BradLewis@users.noreply.github.com>
Date: Mon, 11 Aug 2025 15:20:10 -0400
Subject: Resolve implicit completions with variadic arguments

---
 src/server/symbol.odin | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'src')

diff --git a/src/server/symbol.odin b/src/server/symbol.odin
index 77c4cb0..cf2c4ed 100644
--- a/src/server/symbol.odin
+++ b/src/server/symbol.odin
@@ -557,6 +557,10 @@ get_proc_arg_count :: proc(v: SymbolProcedureValue) -> int {
 get_proc_arg_type_from_index :: proc(value: SymbolProcedureValue, parameter_index: int) -> (^ast.Field, bool) {
 	index := 0
 	for arg in value.arg_types {
+		// We're in a variadic arg, so return true
+		if _, ok := arg.type.derived.(^ast.Ellipsis); ok {
+			return arg, true
+		}
 		for name in arg.names {
 			if index == parameter_index {
 				return arg, true
-- 
cgit v1.2.3


From d31fe63071eb65dd57f9fe08442ce45d3688201d Mon Sep 17 00:00:00 2001
From: Brad Lewis <22850972+BradLewis@users.noreply.github.com>
Date: Mon, 11 Aug 2025 15:28:53 -0400
Subject: Provide completions when defining a variadic argument

---
 src/server/completion.odin  |  6 +++++-
 tests/completions_test.odin | 16 ++++++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/server/completion.odin b/src/server/completion.odin
index 9430235..d1a630a 100644
--- a/src/server/completion.odin
+++ b/src/server/completion.odin
@@ -107,7 +107,11 @@ get_completion_list :: proc(
 					completion_type = .Selector
 				}
 			}
-		} else {
+		} else if _, ok := position_context.selector.derived.(^ast.Implicit_Selector_Expr); !ok {
+			// variadic args seem to work by setting it as an implicit selector expr, in that case
+			// we want an identifier (eg. foo :: proc(args: ..{*}))
+
+			// Otherwise it's a selector
 			completion_type = .Selector
 		}
 	}
diff --git a/tests/completions_test.odin b/tests/completions_test.odin
index 6a3996e..675002e 100644
--- a/tests/completions_test.odin
+++ b/tests/completions_test.odin
@@ -4307,3 +4307,19 @@ ast_completion_enum_variadiac_args :: proc(t: ^testing.T) {
 	}
 	test.expect_completion_docs( t, &source, "", {"A", "B", "C"})
 }
+
+@(test)
+ast_completion_proc_variadiac_arg :: proc(t: ^testing.T) {
+	source := test.Source {
+		main     = `package test
+		Foo :: enum {
+			A,
+			B,
+			C,
+		}
+
+		foo :: proc(foos: ..{*}) {}
+		`,
+	}
+	test.expect_completion_docs( t, &source, "", {"test.Foo: enum {..}"})
+}
-- 
cgit v1.2.3