diff options
| author | gingerBill <gingerBill@users.noreply.github.com> | 2024-03-24 13:26:35 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-24 13:26:35 +0000 |
| commit | 2e416c1a48092d33f53135d77580f72adb1e585b (patch) | |
| tree | 435b9e6b67db37efb0045c6a85cd48184a397e3d /src/linker.cpp | |
| parent | 34247b2658063621fb97a68a35a7b96e459398e0 (diff) | |
| parent | 15c1e8274dc19735ca9857962424846148596d26 (diff) | |
Merge pull request #3316 from laytan/fix-ld-warnings-and-set-default-minimum-version
darwin: fix ld warnings and set minimum os version
Diffstat (limited to 'src/linker.cpp')
| -rw-r--r-- | src/linker.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/linker.cpp b/src/linker.cpp index 9d7f16f1d..6699c9cb8 100644 --- a/src/linker.cpp +++ b/src/linker.cpp @@ -502,7 +502,6 @@ gb_internal i32 linker_stage(LinkerData *gen) { platform_lib_str = gb_string_appendc(platform_lib_str, "-L/opt/local/lib "); } - // This sets a requirement of Mountain Lion and up, but the compiler doesn't work without this limit. if (build_context.minimum_os_version_string.len) { link_settings = gb_string_append_fmt(link_settings, "-mmacosx-version-min=%.*s ", LIT(build_context.minimum_os_version_string)); } @@ -513,7 +512,9 @@ gb_internal i32 linker_stage(LinkerData *gen) { if (!build_context.no_crt) { platform_lib_str = gb_string_appendc(platform_lib_str, "-lm "); if (build_context.metrics.os == TargetOs_darwin) { - platform_lib_str = gb_string_appendc(platform_lib_str, "-lSystem "); + // NOTE: adding this causes a warning about duplicate libraries, I think it is + // automatically assumed/added by clang when you don't do `-nostdlib`. + // platform_lib_str = gb_string_appendc(platform_lib_str, "-lSystem "); } else { platform_lib_str = gb_string_appendc(platform_lib_str, "-lc "); } |