diff options
| author | Laytan Laats <laytanlaats@hotmail.com> | 2024-10-30 15:07:56 +0100 |
|---|---|---|
| committer | Laytan Laats <laytanlaats@hotmail.com> | 2024-10-30 15:51:56 +0100 |
| commit | cc3c9bd87116ce8fcb018719a725a71a16eab3b5 (patch) | |
| tree | 1a0eb282a5846ac537852399290ec0af8b76830c /src/llvm_backend_expr.cpp | |
| parent | f469bbb0049f618d09dd1dd962389c8306db6bbc (diff) | |
fix thread_unix for Darwin after pthread corrections in posix package
afed3ce removed the sys/unix package and moved over to sys/posix, it has
new bindings for the pthread APIs but should have been equivalent (not).
8fb7182 used `CANCEL_ENABLE :: 0`, `CANCEL_DISABLE :: 1`, `CANCEL_DEFERRED :: 0`, `CANCEL_ASYNCHRONOUS :: 1` for Darwin, while the
correct values are `1`, `0`, `2` and `0` respectively (same mistake was made for
FreeBSD in that commit).
What this meant is that the
`pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS)` was not actually
successful, but because the error wasn't checked it was assumed it was.
It also meant `pthread_setcancelstate(PTHREAD_CANCEL_ENABLE)` would
actually be setting `PTHREAD_CANCEL_DISABLE`.
The code in this PR restores the behaviour by now actually deliberately
setting `PTHREAD_CANCEL_DISABLE` and not setting
`PTHREAD_CANCEL_ASYNCHRONOUS` which was the previous behaviour that does
actually seem to work for some reason.
(I also fixed an issue in fmt where `x` would use uppercase if it was a
pointer.)
Diffstat (limited to 'src/llvm_backend_expr.cpp')
0 files changed, 0 insertions, 0 deletions