diff options
| author | gingerBill <bill@gingerbill.org> | 2025-02-24 15:44:38 +0000 |
|---|---|---|
| committer | gingerBill <bill@gingerbill.org> | 2025-02-24 15:44:38 +0000 |
| commit | 344eb6cb42a635f36d669fee8fc25dc37c852ba1 (patch) | |
| tree | 6b51a8733cd29385d49620dba9bd21d42b1a7e5f /src | |
| parent | f56a0a80d3b606b1cbefb973b03b9ddae88bbf48 (diff) | |
Fix name canonicalization for doc writer
Diffstat (limited to 'src')
| -rw-r--r-- | src/docs_writer.cpp | 11 | ||||
| -rw-r--r-- | src/name_canonicalization.cpp | 10 |
2 files changed, 20 insertions, 1 deletions
diff --git a/src/docs_writer.cpp b/src/docs_writer.cpp index 5401e5f76..a92ffc7ad 100644 --- a/src/docs_writer.cpp +++ b/src/docs_writer.cpp @@ -16,6 +16,8 @@ gb_global char const* OdinDocWriterState_strings[] { "writing ", }; +gb_global std::atomic<bool> g_in_doc_writer; + struct OdinDocWriter { CheckerInfo *info; OdinDocWriterState state; @@ -1137,6 +1139,8 @@ gb_internal void odin_doc_write_to_file(OdinDocWriter *w, char const *filename) } gb_internal void odin_doc_write(CheckerInfo *info, char const *filename) { + g_in_doc_writer.store(true); + OdinDocWriter w_ = {}; OdinDocWriter *w = &w_; defer (odin_doc_writer_destroy(w)); @@ -1152,4 +1156,11 @@ gb_internal void odin_doc_write(CheckerInfo *info, char const *filename) { odin_doc_writer_end_writing(w); odin_doc_write_to_file(w, filename); + + g_in_doc_writer.store(false); } + + +gb_internal bool is_in_doc_writer(void) { + return g_in_doc_writer.load(); +}
\ No newline at end of file diff --git a/src/name_canonicalization.cpp b/src/name_canonicalization.cpp index 5d311068f..a80dc1996 100644 --- a/src/name_canonicalization.cpp +++ b/src/name_canonicalization.cpp @@ -520,6 +520,8 @@ write_base_name: return; } +gb_internal bool is_in_doc_writer(void); + // NOTE(bill): This exists so that we deterministically hash a type by serializing it to a canonical string gb_internal void write_type_to_canonical_string(TypeWriter *w, Type *type) { if (type == nullptr) { @@ -719,7 +721,13 @@ gb_internal void write_type_to_canonical_string(TypeWriter *w, Type *type) { return; case Type_Generic: - GB_PANIC("Type_Generic should never be hit"); + if (is_in_doc_writer()) { + type_writer_appendc(w, "$"); + type_writer_append(w, type->Generic.name.text, type->Generic.name.len); + type_writer_append_fmt(w, "%lld", cast(long long)type->Generic.id); + } else { + GB_PANIC("Type_Generic should never be hit"); + } return; case Type_Named: |