aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJasperGeer <jasper.geer@gmail.com>2022-10-26 10:11:10 -0400
committerJasperGeer <jasper.geer@gmail.com>2022-10-26 10:11:10 -0400
commit4b8721a0bbdb2e8b5a7cd13705cd6007040b9a7a (patch)
treeca8806c87b2bc929921a81f9241268c056b4fa15 /src
parent1a0930f841f6704b78d75f7e33eab973d71477d6 (diff)
check addressing mode instead
Diffstat (limited to 'src')
-rw-r--r--src/check_expr.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/check_expr.cpp b/src/check_expr.cpp
index 37254da01..9e48fd8ad 100644
--- a/src/check_expr.cpp
+++ b/src/check_expr.cpp
@@ -1998,7 +1998,7 @@ void check_assignment_error_suggestion(CheckerContext *c, Operand *o, Type *type
error_line("\tSuggestion: a string may be transmuted to %s\n", b);
error_line("\t This is an UNSAFE operation as string data is assumed to be immutable, \n");
error_line("\t whereas slices in general are assumed to be mutable.\n");
- } else if (is_type_u8_slice(src) && are_types_identical(dst, t_string) && o->expr->kind != Ast_CompoundLit) {
+ } else if (is_type_u8_slice(src) && are_types_identical(dst, t_string) && o->mode != Addressing_Constant) {
error_line("\tSuggestion: the expression may be casted to %s\n", b);
}
}
@@ -2039,7 +2039,7 @@ void check_cast_error_suggestion(CheckerContext *c, Operand *o, Type *type) {
}
} else if (are_types_identical(src, t_string) && is_type_u8_slice(dst)) {
error_line("\tSuggestion: a string may be transmuted to %s\n", b);
- } else if (is_type_u8_slice(src) && are_types_identical(dst, t_string) && o->expr->kind != Ast_CompoundLit) {
+ } else if (is_type_u8_slice(src) && are_types_identical(dst, t_string) && o->mode != Addressing_Constant) {
error_line("\tSuggestion: the expression may be casted to %s\n", b);
}
}