aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLaytan Laats <laytanlaats@hotmail.com>2024-04-02 17:20:44 +0200
committerLaytan Laats <laytanlaats@hotmail.com>2024-04-02 17:25:11 +0200
commita8d8696e2fcaccfc34504ec897a6551ff7bfe4b1 (patch)
tree2084ffe695c580481c9848e6c364db0248ad7306 /src
parentbb72ff9c35499078ef5ce22e905ddf919bcc531c (diff)
fix named arguments with #c_vararg
Previously `args=1`, `args={}`, `args={1, 2, 3}` would all crash the compiler. Now it passes them correctly, and if given a compound literal, the values are expanded into the call so you can use a named arg while passing multiple values. Fixes #3168
Diffstat (limited to 'src')
-rw-r--r--src/llvm_backend_proc.cpp21
1 files changed, 21 insertions, 0 deletions
diff --git a/src/llvm_backend_proc.cpp b/src/llvm_backend_proc.cpp
index fba7eb381..7338281dc 100644
--- a/src/llvm_backend_proc.cpp
+++ b/src/llvm_backend_proc.cpp
@@ -3423,6 +3423,27 @@ gb_internal lbValue lb_build_call_expr_internal(lbProcedure *p, Ast *expr) {
if (e->kind == Entity_TypeName) {
lbValue value = lb_const_nil(p->module, e->type);
args[param_index] = value;
+ } else if (is_c_vararg && pt->variadic && pt->variadic_index == param_index) {
+ GB_ASSERT(param_index == pt->param_count-1);
+ Type *slice_type = e->type;
+ GB_ASSERT(slice_type->kind == Type_Slice);
+ Type *elem_type = slice_type->Slice.elem;
+
+ if (fv->value->kind == Ast_CompoundLit) {
+ ast_node(literal, CompoundLit, fv->value);
+ for (Ast *var_arg : literal->elems) {
+ lbValue arg = lb_build_expr(p, var_arg);
+ if (is_type_any(elem_type)) {
+ array_add(&args, lb_emit_conv(p, arg, c_vararg_promote_type(default_type(arg.type))));
+ } else {
+ array_add(&args, lb_emit_conv(p, arg, c_vararg_promote_type(elem_type)));
+ }
+ }
+ } else {
+ lbValue value = lb_build_expr(p, fv->value);
+ GB_ASSERT(!is_type_tuple(value.type));
+ array_add(&args, lb_emit_conv(p, value, c_vararg_promote_type(value.type)));
+ }
} else {
lbValue value = lb_build_expr(p, fv->value);
GB_ASSERT(!is_type_tuple(value.type));