diff options
| author | Ginger Bill <bill@gingerbill.org> | 2016-08-31 18:29:51 +0100 |
|---|---|---|
| committer | Ginger Bill <bill@gingerbill.org> | 2016-08-31 18:29:51 +0100 |
| commit | ff6e21cb879397982cddf3cf5f47bba681271a2c (patch) | |
| tree | 2efa735b9ae420868013da55f38e3c20338cf4a3 /src | |
| parent | 5399463d9d9f94a20fb6b80814318e2b154b199a (diff) | |
Fix subtype polymorphism
Diffstat (limited to 'src')
| -rw-r--r-- | src/checker/expr.cpp | 8 | ||||
| -rw-r--r-- | src/codegen/ssa.cpp | 43 |
2 files changed, 36 insertions, 15 deletions
diff --git a/src/checker/expr.cpp b/src/checker/expr.cpp index 0b9c056ef..81a8a3d10 100644 --- a/src/checker/expr.cpp +++ b/src/checker/expr.cpp @@ -15,7 +15,7 @@ void update_expr_type (Checker *c, AstNode *e, Type *type, b32 fina -b32 check_is_assignable_to_using_subtype(Checker *c, Type *dst, Type *src) { +b32 check_is_assignable_to_using_subtype(Type *dst, Type *src) { Type *prev_src = src; // Type *prev_dst = dst; src = get_base_type(type_deref(src)); @@ -35,6 +35,10 @@ b32 check_is_assignable_to_using_subtype(Checker *c, Type *dst, Type *src) { return true; } } + b32 ok = check_is_assignable_to_using_subtype(dst, f->type); + if (ok) { + return true; + } } } } @@ -91,7 +95,7 @@ b32 check_is_assignable_to(Checker *c, Operand *operand, Type *type, b32 is_argu if (is_argument) { // NOTE(bill): Polymorphism for subtyping - if (check_is_assignable_to_using_subtype(c, type, src)) { + if (check_is_assignable_to_using_subtype(type, src)) { return true; } } diff --git a/src/codegen/ssa.cpp b/src/codegen/ssa.cpp index 3f02b16aa..2f7c13dd8 100644 --- a/src/codegen/ssa.cpp +++ b/src/codegen/ssa.cpp @@ -1288,7 +1288,34 @@ ssaValue *ssa_emit_string(ssaProcedure *proc, ssaValue *elem, ssaValue *len) { return str; } - +String lookup_polymorphic_field(CheckerInfo *info, Type *dst, Type *src) { + Type *prev_src = src; + // Type *prev_dst = dst; + src = get_base_type(type_deref(src)); + // dst = get_base_type(type_deref(dst)); + b32 src_is_ptr = src != prev_src; + // b32 dst_is_ptr = dst != prev_dst; + + GB_ASSERT(src->kind == Type_Struct); + for (isize i = 0; i < src->Struct.field_count; i++) { + Entity *f = src->Struct.fields[i]; + if (f->kind == Entity_Variable && f->Variable.anonymous) { + if (are_types_identical(dst, f->type)) { + return f->token.string; + } + if (src_is_ptr && is_type_pointer(dst)) { + if (are_types_identical(type_deref(dst), f->type)) { + return f->token.string; + } + } + String name = lookup_polymorphic_field(info, dst, f->type); + if (name.len > 0) { + return name; + } + } + } + return make_string(""); +} ssaValue *ssa_emit_conv(ssaProcedure *proc, ssaValue *value, Type *t, b32 is_argument) { @@ -1394,18 +1421,8 @@ ssaValue *ssa_emit_conv(ssaProcedure *proc, ssaValue *value, Type *t, b32 is_arg Type *sb = get_base_type(type_deref(src)); b32 src_is_ptr = src != sb; if (sb->kind == Type_Struct) { - // NOTE(bill): Check - String field_name = {}; - for (isize i = 0; i < sb->Struct.field_count; i++) { - Entity *f = sb->Struct.fields[i]; - if (f->kind == Entity_Variable && f->Variable.anonymous) { - if (are_types_identical(t, f->type)) { - field_name = f->token.string; - break; - } - } - } - + String field_name = lookup_polymorphic_field(proc->module->info, t, src); + // gb_printf("field_name: %.*s\n", LIT(field_name)); if (field_name.len > 0) { // NOTE(bill): It can be casted Selection sel = lookup_field(sb, field_name, false); |